Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sic: add page #5694

Merged
merged 13 commits into from
Apr 7, 2021
Merged

sic: add page #5694

merged 13 commits into from
Apr 7, 2021

Conversation

Waples
Copy link
Member

@Waples Waples commented Apr 6, 2021

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

@tldr-bot
Copy link

tldr-bot commented Apr 6, 2021

The build for this PR failed with the following error(s):

pages/linux/sic.md:3: TLDR003 Descriptions should start with a capital letter
pages/linux/sic.md:7: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:11: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:15: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:19: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:23: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:27: TLDR102 Example description probably not properly annotated

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Apr 6, 2021

The build for this PR failed with the following error(s):

pages/linux/sic.md:3: TLDR003 Descriptions should start with a capital letter
pages/linux/sic.md:7: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:11: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:15: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:19: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:23: TLDR102 Example description probably not properly annotated
pages/linux/sic.md:27: TLDR102 Example description probably not properly annotated

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Apr 6, 2021

The build for this PR failed with the following error(s):

pages/linux/sic.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@Waples
Copy link
Member Author

Waples commented Apr 6, 2021

suckless doesn't use Capital letters. Can we get a pass on TLDR003 ?

@tldr-bot
Copy link

tldr-bot commented Apr 6, 2021

The build for this PR failed with the following error(s):

pages/linux/sic.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@tldr-bot
Copy link

tldr-bot commented Apr 6, 2021

The build for this PR failed with the following error(s):

pages/linux/sic.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@waldyrious
Copy link
Member

suckless doesn't use Capital letters. Can we get a pass on TLDR003 ?

Do you mean that "sic" is meant to stand for "simple irc client", all in lowercase? I don't think we need to conform to stylistic preferences of the projects we document, as long as the content itself is accurate. We can accommodate stylization of names themselves (as we do e.g. with LaTeX), but the descriptions in tldr pages are meant to be useful and informative, not to represent the project's branding.

I would go with:

# sic
> Simple IRC client.

@owenvoke
Copy link
Member

owenvoke commented Apr 6, 2021

I think it should be fine to just use Simple instead of simple...

sbrl
sbrl previously requested changes Apr 6, 2021
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page, @Waples! I've left some comments below for you to review.

pages/linux/sic.md Outdated Show resolved Hide resolved
pages/linux/sic.md Outdated Show resolved Hide resolved
pages/linux/sic.md Outdated Show resolved Hide resolved

- Usage with highlighted alerts on mention of your username:

`sic | awk '/username/ {printf "\a"}1'`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example seems to demonstrate the usage of the awk command, rather than the sic command. Generally in tldr pages we try to keep pages focused on the command they are about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this example demonstrates how you can highlight a message when your username is mentioned when using sic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure if we should keep this example.

pages/linux/sic.md Outdated Show resolved Hide resolved
@Waples
Copy link
Member Author

Waples commented Apr 6, 2021

Yes, sic stands literally for simple irc client, all in lower case @waldyrious. Fair enough, but I like to honor the title of the project/product at least. Simplistic; it's sic. (sometimes TLDR003 is not needed imo).

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@tldr-bot
Copy link

tldr-bot commented Apr 6, 2021

The build for this PR failed with the following error(s):

pages/linux/sic.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@Waples
Copy link
Member Author

Waples commented Apr 6, 2021

@sbrl you should try out sic, it will make more sense ;]

@bl-ue bl-ue added the new command Issues requesting creation of a new page. label Apr 6, 2021
pages/linux/sic.md Outdated Show resolved Hide resolved
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@tldr-bot
Copy link

tldr-bot commented Apr 6, 2021

The build for this PR failed with the following error(s):

pages/linux/sic.md:3: TLDR003 Descriptions should start with a capital letter

Please fix the error(s) and push again.

@bl-ue
Copy link
Contributor

bl-ue commented Apr 6, 2021

Regarding the casing, I admit that I agree with @waldyrious's opinion. As he stated, we're not required to adhere to the projects particular formats, and as 'simple irc client' is merely a description, changing it to match our existing ~3000 pages is the best course of action. Over the years, there have been many such discussions about this exemption or that, but in the end, the simplest, approach most consistent with the rest of the pages is chosen, because otherwise the exceptions pile up and become very difficult to manage.

@Waples
Copy link
Member Author

Waples commented Apr 6, 2021

@bl-ue then what ya think about.... Suckless: sic / Suckless: sic, simple irc client ?

I've got more suckless things I wanna add I think, so what's yer thought hmmn?

@Waples
Copy link
Member Author

Waples commented Apr 6, 2021

simple irc client is also the name (hence sic)

@Waples Waples requested review from sbrl and bl-ue April 7, 2021 10:43
@bl-ue
Copy link
Contributor

bl-ue commented Apr 7, 2021

@Waples:

  • I'd think that a user would mentally match sic with Simple IRC client, so I think that's all that's necessary
  • Also, that the tool is a suckless tool is made obvious by the link.

What do you think?

@Waples
Copy link
Member Author

Waples commented Apr 7, 2021

@bl-ue

Simple IRC client.

already changed that.

Shall i remove the link from the 2nd description line?

@bl-ue
Copy link
Contributor

bl-ue commented Apr 7, 2021

I would; doesn't seem that useful given it's on the very next line (albeit slightly dissimilar, I don't think it matters much though)

@Waples
Copy link
Member Author

Waples commented Apr 7, 2021

fixed

@Waples
Copy link
Member Author

Waples commented Apr 7, 2021

bump @sbrl

pages/linux/sic.md Outdated Show resolved Hide resolved
@bl-ue bl-ue changed the title suckless-sic: add page sic: add page Apr 7, 2021
pages/linux/sic.md Outdated Show resolved Hide resolved
pages/linux/sic.md Outdated Show resolved Hide resolved
@waldyrious
Copy link
Member

@Waples thanks for your patience with our review comments! The page looks quite good now — I left just a few comments inline, please take a look.

Waples and others added 3 commits April 7, 2021 15:55
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
Co-authored-by: Waldir Pimenta <waldyrious@gmail.com>
@Waples
Copy link
Member Author

Waples commented Apr 7, 2021

applied suggestions

Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — thanks again @Waples for the submission and patience! Since this already has two approvals, I'll go ahead and merge after I add my own.

@waldyrious waldyrious dismissed sbrl’s stale review April 7, 2021 17:55

The requested changes have been implemented.

@waldyrious waldyrious merged commit 8830f26 into tldr-pages:master Apr 7, 2021
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not getting back to this. @Waples: That awk example was indeed showing highlighted messages, but it did not do so by calling sic with different arguments - hence it would be a better fit for a wider cheat sheet as opposed to a compact tldr page.

No need to send bump messages to get my attention - it was in my notifications list - I just haven't had time to return to this until now.

@Waples Waples deleted the suckless-sic branch April 13, 2021 08:17
@bl-ue bl-ue mentioned this pull request Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants