-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pio-package: add page #5713
pio-package: add page #5713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my suggestions. The valid extensions are .tar.gz
and .zip
; I picked .tar.gz
because it's more Unix oriented and is traditionally what's meant by 'tarball'. I think it's good to have extensions on the tarball paths though because it makes it clear that they're to be files and not folders.
Also, I removed 'package' from 'current package directory' because that looks just a tad bit odd to me, and I think it conveys the same meaning without it; however, you can ignore that change if you want to.
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Actually I think that you can either specify a file or a directory.
|
Oh, I didn't notice that message. Well, I doubt that it matters to document that...but idk. |
Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
I'd say that's what the |
For #5517