Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pio-package: add page #5713

Merged
merged 5 commits into from
Apr 10, 2021
Merged

Conversation

marchersimon
Copy link
Collaborator

For #5517

@marchersimon marchersimon added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Apr 8, 2021
@marchersimon marchersimon mentioned this pull request Apr 8, 2021
23 tasks
Copy link
Contributor

@bl-ue bl-ue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my suggestions. The valid extensions are .tar.gz and .zip; I picked .tar.gz because it's more Unix oriented and is traditionally what's meant by 'tarball'. I think it's good to have extensions on the tarball paths though because it makes it clear that they're to be files and not folders.

Also, I removed 'package' from 'current package directory' because that looks just a tad bit odd to me, and I think it conveys the same meaning without it; however, you can ignore that change if you want to.

pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
pages/common/pio-package.md Outdated Show resolved Hide resolved
pages/common/pio-package.md Outdated Show resolved Hide resolved
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@marchersimon
Copy link
Collaborator Author

marchersimon commented Apr 8, 2021

The valid extensions are .tar.gz and .zip; I picked .tar.gz because it's more Unix oriented and is traditionally what's meant by 'tarball'. I think it's good to have extensions on the tarball paths though because it makes it clear that they're to be files and not folders.

Actually I think that you can either specify a file or a directory.

pio package publish [<source directory, tar.gz or zip>] [OPTIONS]

@bl-ue
Copy link
Contributor

bl-ue commented Apr 9, 2021

Actually I think that you can either specify a file or a directory.

Oh, I didn't notice that message. Well, I doubt that it matters to document that...but idk.

Co-authored-by: Axel Navarro <navarroaxel@gmail.com>
@marchersimon
Copy link
Collaborator Author

I'd say that's what the More information link is for.

@bl-ue bl-ue requested a review from navarroaxel April 9, 2021 15:47
@navarroaxel navarroaxel merged commit 3815dd2 into tldr-pages:master Apr 10, 2021
@marchersimon marchersimon deleted the pio-package branch April 10, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants