Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pio-test: add page #5815

Merged
merged 3 commits into from
May 1, 2021
Merged

pio-test: add page #5815

merged 3 commits into from
May 1, 2021

Conversation

marchersimon
Copy link
Collaborator

For #5517

@marchersimon marchersimon added the new command Issues requesting creation of a new page. label Apr 22, 2021
@marchersimon marchersimon mentioned this pull request Apr 22, 2021
Closed
23 tasks
sbrl
sbrl requested changes Apr 22, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new page! I've left some comments below for you to review.

pages/common/pio-test.md Outdated Show resolved Hide resolved
pages/common/pio-test.md Outdated Show resolved Hide resolved
pages/common/pio-test.md Outdated Show resolved Hide resolved
pages/common/pio-test.md Show resolved Hide resolved
@marchersimon @sbrl
Apply suggestions from code review
dd423bb 
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
bl-ue
bl-ue reviewed Apr 22, 2021
View reviewed changes
pages/common/pio-test.md Outdated Show resolved Hide resolved
bl-ue
bl-ue reviewed Apr 22, 2021
View reviewed changes
pages/common/pio-test.md Outdated Show resolved Hide resolved
@marchersimon @bl-ue
Mention glob pattern
540341c 
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
@marchersimon marchersimon requested a review from sbrl April 23, 2021 11:28
sbrl
sbrl approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @marchersimon!

@sbrl sbrl merged commit 6e6711f into tldr-pages:master May 1, 2021
@marchersimon marchersimon deleted the pio-test branch May 1, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@Waples Waples Waples approved these changes

@sbrl sbrl sbrl approved these changes

@navarroaxel navarroaxel navarroaxel approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marchersimon @navarroaxel @sbrl @Waples @bl-ue