Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme.sh-dns: add page; acme.sh: remove example #5852

Merged
merged 9 commits into from
May 14, 2021

Conversation

peterbabic
Copy link
Contributor

The wildcard went completely missing somewhere before the merge. In the original design, wildcard certificate usage was about to be referenced with a manual mode example. Running a manual mode with the current example would not produce a wildcard certificate because of the missing *. subdomain. Furthermore, it would not do anything because a manual DNS mode requires a sort of confirmation command, more info acmesh-official/acme.sh#1029. Because of the many quirks of the various DNS modes, a separate subcommand page acme.sh dns was created.

The wildcard went completely missing somewhere before the merge. In the original
design, wildcard certificate usage was about to be referenced with a manual mode example. Running a manual mode with the current example would not produce a wildcard certificate because of the missing \*. subdomain. Furthermore, it would not do anything because a manual DNS mode requires a sort of confirmation command, more info acmesh-official/acme.sh#1029. Because of the many quirks of the various DNS modes, a separate subcommand page `acme.sh dns` was created.
See also the previous commit description.
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/acme.sh-dns.md:4: TLDR004 Command descriptions should end in a period

Please fix the error(s) and push again.

@peterbabic peterbabic changed the title Acme.sh dns acme.sh: add dns subcommand Apr 28, 2021
@peterbabic peterbabic changed the title acme.sh: add dns subcommand acme.sh-dns: add page Apr 28, 2021
@bl-ue bl-ue added new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s). labels Apr 28, 2021
@bl-ue bl-ue changed the title acme.sh-dns: add page acme.sh-dns: add page; acme.sh: remove example Apr 28, 2021
There should not be slash before the asterisk. I am not sure why it sometimes needs to escape the asterisk an sometimes not.
@peterbabic peterbabic requested a review from Waples April 28, 2021 19:29
@peterbabic
Copy link
Contributor Author

Guys, additionally, should we also mention custom scripts, I have described in #5823 (comment)

It would almost certainly require referencing a path in the example description and I am not sure if we do that. Without the actual path the example does not make much sense.

@marchersimon
Copy link
Collaborator

I don't think that should be a problem.

@peterbabic peterbabic mentioned this pull request May 1, 2021
@sbrl
Copy link
Member

sbrl commented May 1, 2021

In tldr pages we generally try to only document the most common functionality in a page - it's an exercise in determining what's most important. So while custom scripts might be a very useful feature, it sounds like advanced functionality that doesn't necessarily need documenting here. Perhaps it would be more useful in a long-form guide or tutorial rather than a concise set of examples like tldr pages?

Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edit and new page! I've left some comments below for you to review.

@peterbabic
Copy link
Contributor Author

peterbabic commented May 1, 2021

So while custom scripts might be a very useful feature, it sounds like advanced functionality that doesn't necessarily need documenting here

@sbrl Agreed.

@marchersimon above + can you provide an existing example/discussion of a good way to insert a path into the page, for a possible future use (only if you do not need to search for it for too long).

peterbabic and others added 2 commits May 1, 2021 20:57
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@sbrl
Copy link
Member

sbrl commented May 1, 2021

Generally the convention with file paths is:

path/to/file is preferred, with the preferred extension after it if appropriate - e.g. path/to/file.txt

If the path must be absolute, then prepend a slash (the word absolute is suggested but not required): /absolute/path/to/file.txt

Generally speaking we drop the path/to/ bit if we need to specify lots of paths at once - e.g. tar

If you need to specify a variable number of paths, see #5791

@peterbabic
Copy link
Contributor Author

@sbrl thank you. Do these convention apply to the actual text? Am I allowed to use backtics in the text to specify the path?

---- example below ----

  • Issue a certificate using a custom DNS API script, placed by default at /root/.acme.sh/dns_custom.sh (useful when the API is not yet supported upstream):

acme.sh --issue --dns dns_custom --domain example.com

Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@marchersimon
Copy link
Collaborator

@peterbabic we actually use backticks in normal text a lot. Mostly when refering to a command or for URLs.

peterbabic and others added 2 commits May 5, 2021 20:21
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
@marchersimon marchersimon requested a review from sbrl May 10, 2021 19:57
Copy link
Member

@sbrl sbrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @peterbabic!

@sbrl sbrl merged commit 345a2d8 into tldr-pages:main May 14, 2021
@peterbabic peterbabic deleted the acme.sh-dns branch May 14, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command. page edit Changes to an existing page(s).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants