-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acme.sh-dns: add page; acme.sh: remove example #5852
Conversation
The wildcard went completely missing somewhere before the merge. In the original design, wildcard certificate usage was about to be referenced with a manual mode example. Running a manual mode with the current example would not produce a wildcard certificate because of the missing \*. subdomain. Furthermore, it would not do anything because a manual DNS mode requires a sort of confirmation command, more info acmesh-official/acme.sh#1029. Because of the many quirks of the various DNS modes, a separate subcommand page `acme.sh dns` was created.
See also the previous commit description.
The build for this PR failed with the following error(s):
Please fix the error(s) and push again. |
There should not be slash before the asterisk. I am not sure why it sometimes needs to escape the asterisk an sometimes not.
Guys, additionally, should we also mention custom scripts, I have described in #5823 (comment) It would almost certainly require referencing a path in the example description and I am not sure if we do that. Without the actual path the example does not make much sense. |
I don't think that should be a problem. |
In tldr pages we generally try to only document the most common functionality in a page - it's an exercise in determining what's most important. So while custom scripts might be a very useful feature, it sounds like advanced functionality that doesn't necessarily need documenting here. Perhaps it would be more useful in a long-form guide or tutorial rather than a concise set of examples like tldr pages? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edit and new page! I've left some comments below for you to review.
@sbrl Agreed. @marchersimon above + can you provide an existing example/discussion of a good way to insert a path into the page, for a possible future use (only if you do not need to search for it for too long). |
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
Generally the convention with file paths is:
If the path must be absolute, then prepend a slash (the word Generally speaking we drop the If you need to specify a variable number of paths, see #5791 |
@sbrl thank you. Do these convention apply to the actual text? Am I allowed to use backtics in the text to specify the path? ---- example below ----
|
Co-authored-by: Starbeamrainbowlabs <sbrl@starbeamrainbowlabs.com>
@peterbabic we actually use backticks in normal text a lot. Mostly when refering to a command or for URLs. |
Following suggestion at tldr-pages#5852 (comment)
Co-authored-by: marchersimon <50295997+marchersimon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @peterbabic!
The wildcard went completely missing somewhere before the merge. In the original design, wildcard certificate usage was about to be referenced with a manual mode example. Running a manual mode with the current example would not produce a wildcard certificate because of the missing *. subdomain. Furthermore, it would not do anything because a manual DNS mode requires a sort of confirmation command, more info acmesh-official/acme.sh#1029. Because of the many quirks of the various DNS modes, a separate subcommand page
acme.sh dns
was created.