-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux/[a-g]: add more information link #6076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks. I rewieved everything until chage
for now, more is comming as soon as I have time for it.
I converted this PR to a draft — feel free to undo that once you're ready for review, @Stig124 :) |
@Stig124 you'll probably want to use https://github.com/tldr-pages/tldr/blob/main/scripts/set-more-info-link.py, if you're not already. It saves a lot of headache when dealing with the more infos 😅 |
Oh, and also please have a look at https://lukwebsforge.github.io/tldri18n/#linux to see if any pages have translations. Those should also be updated. This can be done automatically with this script as @bl-ue just mentioned above by just running |
Oh thanks |
And that script is broken |
|
If I have time I will fix that |
@bl-ue in cases like this it probably would be easier to first add all links to the English pages and one we agree on all of them just run a script to automatically update the links in all translated pages. Wdyt? |
@Stig124 did you run the script with |
@Stig124
|
@marchersimon Yeah, that sounds like a good idea. 👍🏻 |
@bl-ue why don't we just add |
Why isn't the shebang set though? |
@marchersimon that's a great idea. @Stig124 simply because I've never though of it. Go ahead and open a PR to add it, if you'd like :). Use |
I just f* up my branches on my fork, can't do the fix now |
Why? I don't think so. Just open a PR for the https://github.com/Stig124/tldr/tree/sfix2 branch. |
It has all of the link commits, so I'm unable |
I put the fix in this commit |
Ah, I see. Just checkout
|
I'd prefer that go in its own PR. Just leave it in this PR though, and make a new PR per my instructions above. Then, once it's merged, we'll update this PR, and that should essentially fix it all. |
Yes please, sorry for not having been able to finish that PR @marchersimon |
No problem at all. Thanks for the work so far. |
Ok, my review was requested so here it is: GEdit, flatpak need fixing and if possible fsck |
@CleanMachine1 I've already made suggestions for GEdit and flatpak. Are those links okay? And I don't see whats wrong with fsck. |
Yes. However I have 1 more thing to mention. #6062 needs to have ALL ticked off. I am sure someone here can use some wizardry to auto do all of them here using a replace tool or whatever |
Any thoughts on my suggestions above? If not I'll commit them. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All suggestions are applied and all translated pages are in sync. I think this PR is ready to be merged.
Cant review on mobile from what I see but this has my approval |
It's possible to review by clicking on the |
Partial fix for #6062 on the linux side of pages, with commits notarized by letters