Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited CONTRIBUTING.md to reflect final convention. #634

Merged
merged 1 commit into from
Jan 7, 2016

Conversation

rubenvereecken
Copy link
Contributor

I changed the tldr page example in CONTRIBUTING.md, the starting point for most of our contributors. This way we should have some nicely new-looking pages in no time.

I also took ahold of the opportunity to add examples that demonstrate the naming convention that we've been using, then explained it afterwards. Happy to debate this bit, but I feel we've already done a fair bit of discussing on that. If we do, I'll split this PR and merge in the first bit. It's urgent.

@rubenvereecken rubenvereecken added page edit Changes to an existing page(s). clients Issues pertaining to a particular client or the clients as whole. labels Jan 7, 2016
@igorshubovych
Copy link
Collaborator

LGTM!

@leostera
Copy link
Contributor

leostera commented Jan 7, 2016

👍

rubenvereecken pushed a commit that referenced this pull request Jan 7, 2016
Edited CONTRIBUTING.md to reflect final convention.
@rubenvereecken rubenvereecken merged commit 545b107 into tldr-pages:master Jan 7, 2016
@waldyrious waldyrious added syntax Issues related to the content and markup of the pages. and removed clients Issues pertaining to a particular client or the clients as whole. labels Feb 7, 2016
@waldyrious waldyrious removed the page edit Changes to an existing page(s). label Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
syntax Issues related to the content and markup of the pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants