Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gifsicle: update page #8403

Merged
merged 9 commits into from
Aug 30, 2022
Merged

gifsicle: update page #8403

merged 9 commits into from
Aug 30, 2022

Conversation

CairnThePerson
Copy link
Collaborator

I reworked the existing page and added some more examples.

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 1.93

@github-actions github-actions bot added the page edit Changes to an existing page(s). label Aug 27, 2022
@tldr-bot
Copy link

The build for this PR failed with the following error(s):

pages/common/gifsicle.md:32:110 MD047/single-trailing-newline Files should end with a single newline character
pages/common/gifsicle.md:1: TLDR009 Page should contain a newline at end of file

Please fix the error(s) and push again.

mfrw
mfrw reviewed Aug 27, 2022
View reviewed changes
pages/common/gifsicle.md Outdated Show resolved Hide resolved
@CairnThePerson
gifsicle: update page
43e3a88 
I reworked the existing page and added some more examples.
@CleanMachine1
Copy link
Member

Avoid force pushing and squashing, we squash when merging regardless.

@CairnThePerson
Copy link
Collaborator Author

Avoid force pushing and squashing, we squash when merging regardless.

Got it. I'll just add new commits in the future.

CairnThePerson and others added 3 commits August 26, 2022 23:08
@CairnThePerson
Remove extraneous editing options comment
d60808f
@CairnThePerson
Switch "input" to "output"
f2c4137
@CairnThePerson @CleanMachine1
Reduce wordiness by using "compression"
af6d764 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
CleanMachine1
CleanMachine1 reviewed Aug 27, 2022
View reviewed changes
pages/common/gifsicle.md Outdated Show resolved Hide resolved
pages/common/gifsicle.md Outdated Show resolved Hide resolved
pages/common/gifsicle.md Outdated Show resolved Hide resolved
pages/common/gifsicle.md Outdated Show resolved Hide resolved
CairnThePerson and others added 4 commits August 27, 2022 10:30
@CairnThePerson @CleanMachine1
Change "animation" to "GIF"
8355320 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@CairnThePerson @CleanMachine1
Change "animation" to "GIF"
5d1690e 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
@CairnThePerson
Simplify make animation line
ee9815d
@CairnThePerson
Simplify final example's description
c0e779e
@CleanMachine1 CleanMachine1 added the review needed Prioritized PRs marked for reviews from maintainers. label Aug 29, 2022
kbdharun
kbdharun approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after implementing @CleanMachine1 's suggestion

@CairnThePerson @CleanMachine1
Clarify frame number
dced2a2 
Co-authored-by: CleanMachine1 <78213164+CleanMachine1@users.noreply.github.com>
mfrw
mfrw approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thank you @CairnThePerson for your contribution :)

@CleanMachine1 CleanMachine1 merged commit d360ef4 into tldr-pages:main Aug 30, 2022
@CairnThePerson CairnThePerson deleted the gifsicle branch September 1, 2022 14:12
@CleanMachine1 CleanMachine1 mentioned this pull request Sep 1, 2022
Closed
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CleanMachine1 CleanMachine1 CleanMachine1 approved these changes

@kbdharun kbdharun kbdharun approved these changes

@mfrw mfrw mfrw approved these changes

@navarroaxel navarroaxel Awaiting requested review from navarroaxel

Assignees
No one assigned
Labels
page edit Changes to an existing page(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CairnThePerson @tldr-bot @CleanMachine1 @navarroaxel @mfrw @kbdharun