Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update PyInstaller + packaging fixes #282

Merged
merged 4 commits into from
Jul 22, 2024
Merged

chore(deps): update PyInstaller + packaging fixes #282

merged 4 commits into from
Jul 22, 2024

Conversation

tlecomte
Copy link
Owner

@tlecomte tlecomte commented Jul 22, 2024 •
edited
Loading

PyInstaller 5.12+ should fix an error with Python 3.11.4+, so we upgrade to latest.

See pyinstaller/pyinstaller#7694

Apply some packaging fixes:

  • the playback control dll needed to be added in pyinstaller data files, since it's not in the root folder
  • fix a path for Macos following a breaking change in the app structure with PyInstaller 6.0+
  • remove icu dll on windows, it's apparently not included anymore

@tlecomte tlecomte changed the title chore(deps): update PyInstaller chore(deps): update PyInstaller + packaging fixes Jul 22, 2024
@tlecomte tlecomte merged commit 879a0bf into master Jul 22, 2024
8 checks passed
@tlecomte tlecomte deleted the dev/tlecomte-pyinstaller branch July 22, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tlecomte