feat: migrate spectrogram to QtQuick/QML #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last widget to be migrated. The benefits have to do with the easier layout code mostly. For now, this is implemented with QQuickPaintedItem to expedite the migration, so there is not much performance benefit (10% less CPU nevertheless), but this could be revisited if one day we move to Qt6 to use a texture node in the scene graph. Also, there could be a round of extra refactoring in the future to remove some of the classes, the current state has a bit of redundancy.
tlecomte
force-pushed
the
qmlSpectrogram
branch
from
9d1f893 to
ab5691c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last widget to be migrated. The benefits have to do with the easier layout code mostly.
For now, this is implemented with QQuickPaintedItem to expedite the migration, so there is not much performance benefit (10% less CPU nevertheless), but this could be revisited if one day we move to Qt6 to use a texture node in the scene graph.
Also, there could be a round of extra refactoring in the future to remove some of the classes, the current state has a bit of redundancy.