Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in min_coverage filter #138

Closed
tleonardi opened this issue Jun 5, 2020 · 0 comments
Closed

Bug in min_coverage filter #138

tleonardi opened this issue Jun 5, 2020 · 0 comments

Comments

@tleonardi
Copy link
Owner

tleonardi commented Jun 5, 2020

If a ref_id is completely missing from one of the eventalign files it is not filtered out by the Whitelisting function as it should be.

This is due to the fact that the cond_lab and and sample_lab for the missing condition are not present in ref_dict, and therefore the assertion error is never raised.

for cond_lab, cond_dict in ref_dict.items():
valid_dict[cond_lab] = OrderedDict()
for sample_lab, read_list in cond_dict.items():
# Filter out if coverage too low
assert len(read_list) >= min_coverage

tleonardi added a commit that referenced this issue Jun 5, 2020
tleonardi added a commit that referenced this issue Sep 18, 2020
* Ignoring test datasets

* Logging now uses loguru framework

* Fix for issue #138

* Cleanup of logging messages

* Removed now unsused logger argument in call to txCompare()

* Fix for issue #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant