Get gist from url #6
Conversation
There was a problem hiding this comment.
Thank you @hipstersmoothie, and really sorry for the delay.
| @@ -32,13 +32,32 @@ React.render( | |||
| ); | |||
| ``` | |||
|
|
|||
| Gist from URL: | |||
|
|
|||
| ***NOTE: File cannot be parse from the URL. Supply as separate property.*** | |||
There was a problem hiding this comment.
Any reason to this?
I'd say it would be best to get the filename from the url as well.
From a use case perspective, would a user know the url without the file, or everything at once? Like the following url: https://gist.github.com/ringods/5995ea726914f280afb3#file-chef-dockerfile
There was a problem hiding this comment.
Hi @tleunen,
I think it's because you can’t extract the filename from the URL as he said.
As example, by parsing the filename from the url https://gist.github.com/ringods/5995ea726914f280afb3#file-chef-dockerfile, we would get file-chef-dockerfile or maybe chef-dockerfile instead of the real filename which is Chef-Dockerfile.
So, if someone needs to get the real filename on the iframe#id, I think this developer would have to use the Gist#file property.
What do you think?
Currently idk of a way to get the file from the url. URLs do not respect capitalization, and the gist url needs the correct capitalization to get the file. So the user still has to supply the file as a separate property.
closes #3