Merge branch 'multi-close'

src/jd_vars.jl

@@ -147,6 +147,12 @@ function set_vars!(jd_vars::Dict{String, Pair{Any, Tuple}},
     if !isempty(assignments)
         for (key, assign) ∈ assignments
             if haskey(jd_vars, key)
+                # at this point there may still be a comment in the assignment
+                # string e.g. if it came from @def title = "blah" <!-- ... -->
+                # so let's strip <!-- and everything after.
+                # NOTE This is agressive so if it happened that the user wanted # this in a string it would fail (but come on...)
+                idx = findfirst("<!--", assign)
+                !isnothing(idx) && (assign = assign[1:prevind(assign, idx[1])])
                 tmp = Meta.parse("__tmp__ = " * assign)
                 # try to evaluate the parsed assignment
                 try

test/jd_paths_vars.jl

@@ -34,3 +34,13 @@ end
     @test (@test_logs (:error, "I got an error (of type 'DomainError') trying to evaluate '__tmp__ = sqrt(-1)', fix the assignment.") JuDoc.set_vars!(d, ["a"=> "sqrt(-1)"])) == nothing
     @test (@test_logs (:warn, "Doc var name 'blah' is unknown. Assignment ignored.") JuDoc.set_vars!(d, ["blah"=>"1"])) == nothing
 end
+
+
+@testset "Def+coms" begin # see #78
+    st = raw"""
+        @def title = "blah" <!-- comment -->
+        etc
+        """
+    (m, jdv) = J.convert_md(st)
+    @test jdv["title"].first == "blah"
+end