tlsn-core fixtures #359
Merged
tlsn-core fixtures #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinui0
force-pushed
the
feature/fixtures
branch
from
733365f
to
7423750
Compare
Co-authored-by: dan <themighty1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the fixtures (again) into
tlsn-coreand eliminates a cyclic dependency that currently exists betweentlsn-coreandtlsn-fixtures.I would prefer to have the fixtures in a separate crate but we need to use them for tests in
tlsn-coreso this is path of least resistance without a bunch of duplication.Changes
tlsn-fixturesinto a module intlsn-corefixturestotlsn-core--all-featuresin our CI