Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify notary url parsing to make it generic for both ip and domain #366

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Modify notary url parsing to make it generic for both ip and domain #366

merged 2 commits into from
Oct 17, 2023

Conversation

yuroitaki
Copy link
Member

@yuroitaki yuroitaki commented Oct 17, 2023 •
edited
Loading

Make it generic to parse notary url in the prover example — so that we can just easily use ip address or domain name as the notary host

heeckhau
heeckhau approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@heeckhau heeckhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yuroitaki yuroitaki merged commit 8783a62 into dev Oct 17, 2023
12 checks passed
@sinui0 sinui0 deleted the fix/example-notary-url branch October 17, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heeckhau heeckhau heeckhau approved these changes

@sinui0 sinui0 Awaiting requested review from sinui0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuroitaki @heeckhau