Add api key whitelist hot reloading and small touch-up #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuroitaki
commented
Mar 18, 2024
yuroitaki
commented
Mar 18, 2024
sinui0
requested changes
Apr 2, 2024
yuroitaki
commented
Apr 3, 2024
sinui0
approved these changes
Apr 3, 2024
sinui0
pushed a commit
that referenced
this pull request
Apr 9, 2024
* Add hot reload of api key, remove prover ip, move html static text. * Add documentation. * Toggle back config, add comments. * Edit comment and html info. * Edit comment. * Change to sync mutex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly adds hot reloading capability of api key whitelist, i.e. modification of the whitelist file will be automatically applied without needing to restart the server.
There are also some small touchups on the code