fix lightgbm testing order

tlverse · Apr 22, 2021 · ad43f25 · ad43f25
1 parent 0444902
commit ad43f25
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/man/Lrnr_haldensify.Rd b/man/Lrnr_haldensify.Rd
diff --git a/tests/testthat/test-lightgbm.R b/tests/testthat/test-lightgbm.R
@@ -24,6 +24,7 @@ test_learner <- function(learner, task, ...) {
   # test learner prediction
   test_that("Learner can generate training set predictions", {
     skip_on_os("windows")
+    fit_obj <- learner_obj$train(task)
     train_preds <- fit_obj$predict()
     expect_equal(
       sl3:::safe_dim(train_preds)[1], length(task$Y)
@@ -33,11 +34,15 @@ test_learner <- function(learner, task, ...) {
   # test learner chaining
   test_that("Chaining returns a task", {
     skip_on_os("windows")
+    fit_obj <- learner_obj$train(task)
     chained_task <- fit_obj$chain()
     expect_true(is(chained_task, "sl3_Task"))
   })
+
   test_that("Chaining returns the correct number of rows", {
     skip_on_os("windows")
+    fit_obj <- learner_obj$train(task)
+    chained_task <- fit_obj$chain()
     expect_equal(nrow(chained_task$X), nrow(task$X))
   })
 }