Plugin crashes Vagrant if nothing is configured #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reported also to hashicorp/vagrant#1877. |
Vagrant does not call `finalize!` if the configuration key is not used in Vagrantfiles: hashicorp/vagrant#1877 Fixes #2.
|
@patcon sure. I feel stupid that I didn't catch that before. We need some integration/acceptance tests. |
tmatilai
added a commit
that referenced
this pull request
Jun 27, 2013
Plugin crashes Vagrant if nothing is configured
|
@tmatilai I'm really interested on discussing integration / acceptance tests strategies for vagrant plugins as I've seem different approaches for doing that :) |
|
:%s/seem/seen/g |
|
@fgrehm I'm all open for suggestions. =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Vagrant does not call
finalize!for the configuration object if there is no configuration for it in the Vagrantfile.This seems like bug or unfortunate feature in Vagrant, bu we should anyway be prepared that the configuration keys can be left in
UNSET_VALUE. A good idea might be to call `finalize ourself.