-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding golint and a Makefile #13
Conversation
git add README.md | ||
git commit -m "chore: Updated coverage badge." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any better workaround or solution to such feature? I don't think it is elegant and proper to commit the README.md
changes within CI/CD scope and interfere the branch that the developers working on, especially when we are doing some traditional GitFlow actions (such as rebase the upstream branch or so).
What do you think @tmc ?
If we are surely use such method to update the badges, I suggest to add a concurrency config in GitHub Actions workflow file to prevent conflicts, you can read more here: https://docs.github.com/en/actions/using-jobs/using-concurrency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or how about we make two workflow definitions:
- Pull Request into
main
, focusing on testing and report the developers - Push into
main
, focusing on updating the test coverages badges
.gitignore
Outdated
@@ -0,0 +1,6 @@ | |||
coverage.txt |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
.github/workflows/golangci-lint.yml
Outdated
- uses: actions/setup-go@v4 | ||
with: | ||
go-version: '1.19' | ||
cache: false |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Neko Ayaka <neko@ayaka.moe>
Co-authored-by: Neko Ayaka <neko@ayaka.moe>
Co-authored-by: Neko Ayaka <neko@ayaka.moe>
Co-authored-by: Neko Ayaka <neko@ayaka.moe>
Co-authored-by: Neko Ayaka <neko@ayaka.moe>
I really like what I'm seeing here, thanks for reviewing @nekomeowww -- good input. |
Co-authored-by: Neko Ayaka <neko@ayaka.moe>
Co-authored-by: Neko Ayaka <neko@ayaka.moe>
There are some conflicts. Remember to get your branch updated 😉 |
Looking forward to a more uniform codebase with conventions to follow. Let's get this in. |
uses: ad-m/github-push-action@master | ||
with: | ||
github_token: ${{ github.token }} | ||
branch: ${{ github.head_ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every file should ends with a empty new line.
branch: ${{ github.head_ref }} | |
branch: ${{ github.head_ref }} | |
You can ask IDE/editors perform such actions automatically, if you are using Visual Studio Code, you could add one line that enable this feature easily:
{
"files.insertFinalNewline": true,
}
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please format the new lines of end of the file?
I believe this is obviated by #42 |
Makefile
that includes tests for golint, ineffassign, gosec, gocov, etc.coverage.yml
to ci for gocovgolintci-lint.yml
to ci for golint