Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring from ssh_config. #200

Merged
merged 20 commits into from
Aug 3, 2024
Merged

Support configuring from ssh_config. #200

merged 20 commits into from
Aug 3, 2024

Conversation

tmds
Copy link
Owner

@tmds tmds commented Jul 18, 2024

Fixes #199.

@tmds
Copy link
Owner Author

tmds commented Jul 19, 2024

@jborean93 if you want, feel free to do a review (quick or in-depth) and add any feedback you may have.

I'm going to let this rest for a week or two, before working to complete it.

Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't say I did an in depth review of the code but what you've got here seems pretty comprehensive. I've just added a few comments on some of the things I've seen.

src/Tmds.Ssh/SshConfig.cs Outdated Show resolved Hide resolved
src/Tmds.Ssh/SshClientSettings.SshConfig.cs Outdated Show resolved Hide resolved
src/Tmds.Ssh/SshConfig.cs Outdated Show resolved Hide resolved
src/Tmds.Ssh/UserAuthentication.cs Outdated Show resolved Hide resolved
@tmds tmds merged commit 0c04b08 into main Aug 3, 2024
2 checks passed
@tmds tmds deleted the ssh_config branch September 16, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ssh_config configuration
2 participants