Add support for encrypted private keys. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried my best to clean up the Bcrypt KDF implementation from SSH.NET but I'm sure there are probably further optimisations that could be implemented. The good news is it works with some test vectors I found and the tests when they run. |
jborean93
commented
Jul 28, 2024
jborean93
force-pushed
the
key-encryption
branch
from
3113597 to
5f19311
Compare
tmds
reviewed
Aug 4, 2024
tmds
reviewed
Aug 4, 2024
tmds
reviewed
Aug 4, 2024
tmds
reviewed
Aug 4, 2024
tmds
reviewed
Aug 4, 2024
|
@jborean93 thanks for working on this! I've added some high level comments about code organization. I'll try to do a more in depth review in the coming week. |
Adds support for using encrypted private keys with user authentication. This implementation support private keys encrypted with the PKCS#1 and OpenSSH PEM formats. The AES and ChaCha20Poly1304 ciphers allowed by each format has been implemented in this change.
jborean93
force-pushed
the
key-encryption
branch
from
5f19311 to
3abd97f
Compare
tmds
reviewed
Aug 7, 2024
tmds
reviewed
Aug 7, 2024
tmds
reviewed
Aug 7, 2024
tmds
reviewed
Aug 7, 2024
tmds
reviewed
Aug 7, 2024
tmds
reviewed
Aug 7, 2024
tmds
reviewed
Aug 10, 2024
tmds
reviewed
Aug 10, 2024
|
Thanks a lot @jborean93! |
|
Thanks for the review and looking through the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for using encrypted private keys with user authentication. This implementation support private keys encrypted with the PKCS#1 and OpenSSH PEM formats. The AES and ChaCha20-Poly1305 ciphers allowed by each format has been implemented in this change.
Fixes: #202