New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support downloading to a Stream (#261) #266

Merged

tmds merged 4 commits into tmds:main from yokrysty:main

Dec 10, 2024

Contributor

yokrysty commented Dec 9, 2024

closes #261


          Support downloading to a Stream (tmds#261)

72c23ea

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpClient.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

test/Tmds.Ssh.Tests/SftpClientTests.cs Outdated Show resolved Hide resolved


          changes in response to PR comments

5b2a781

yokrysty force-pushed the main branch from 97731fe to 5b2a781 Compare

December 9, 2024 18:40

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

test/Tmds.Ssh.Tests/SftpClientTests.cs Outdated Show resolved Hide resolved

Owner

tmds commented Dec 10, 2024

@yokrysty thanks for the updates! I have some more minor request and then this will be good to merge.

Contributor Author

yokrysty commented Dec 10, 2024 •

edited

Loading

@tmds great, almost there, after this i have prepared an implementation for uploading from a stream
i will create a new issue with a PR and i hope you will like the changes on a first try


          changes in response to PR comments part 2

f07a685

Owner

tmds commented Dec 10, 2024

After this i have prepared an implementation for uploading from a stream i will create a new issue with a PR

Note that this one is a bigger challenge. In contrast to the Stream being downloaded to here, the source for an upload isn't read sequentially to enable pipelining the writes. We want to maintain the pipelining for FileStream and preferably also have it for MemoryStream. For an async Stream case, pipelining is not possible. Please create an issue for the feature, and if you make a PR for it, try to handle these different cases.

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Outdated Show resolved Hide resolved

tmds reviewed

View reviewed changes

src/Tmds.Ssh/SftpChannel.cs Show resolved Hide resolved

yokrysty force-pushed the main branch from 41e0d7a to ec6df67 Compare

December 10, 2024 11:20


          changes in response to PR comments part 3

3174efb

yokrysty force-pushed the main branch from 20dc82f to 3174efb Compare

December 10, 2024 11:24

tmds merged commit ace1795 into tmds:main

1 check passed

Owner

tmds commented Dec 10, 2024

Thanks @yokrysty!

yokrysty mentioned this pull request

Support uploading from a Stream #267

Closed

Owner

tmds commented Dec 10, 2024

If you'd like to use this feature before it's released, you can use a package from the CI feed: https://github.com/tmds/Tmds.Ssh?tab=readme-ov-file#ci-feed.

Owner

tmds commented Dec 12, 2024

This is part of 0.9.0 which was just uploaded to nuget.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet