Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AllowHttpStatus overload should take a set of ints, not HttpStatusCodes #785

Closed
tmenier opened this issue Dec 8, 2023 · 0 comments
Closed

Comments

@tmenier
Copy link
Owner

tmenier commented Dec 8, 2023

Flurl (ever opinionated) generally favors expressing HTTP status codes as integers, rather than using .NET's HttpStatusCode enum. While updating the docs I was reminded that it breaks from that convention here:

clientOrRequest.AllowHttpStatus(HttpStatusCode.Conflict, HttpStatusCode.NotFound)...;

Although a breaking change, I'd like to switch it to use ints for 4.0 for consistency with other things:

clientOrRequest.AllowHttpStatus(409, 404)...;
tmenier pushed a commit that referenced this issue Dec 8, 2023
@tmenier tmenier changed the title AllowedHttpStatus overload should take a set of ints, not HttpStatusCodes AllowHttpStatus overload should take a set of ints, not HttpStatusCodes Dec 8, 2023
@tmenier tmenier closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Released
Development

No branches or pull requests

1 participant