-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mod framework #555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
flend
commented
Jun 17, 2023
•
edited
Loading
edited
- Added Rapid Brogue v1.5 variant and ability to switch to variant at run-time (when game not in progress). Switching variants currently implemented on the command line at game startup only.
- Adds src/variants. Each variant defines a struct of game constants, its own table variables, and a function to switch the global variables for constants and tables pointers to the variant's own.
- Many #defines replaced with variant-specific game constants.
- Globals files tidied up and globals made const where possible. Many color functions now accept const colors.
- Implemented hard by-level item gen and charm minimum recharge duration, used in Rapid Brogue variant.
- Game variants have their own high scores file.
- Variant versions are saved in the recording header, core game version is not saved (since variant version determines recording compatibility).
flend
force-pushed
the
feature/mod_framework
branch
from
June 17, 2023 21:27
4792319
to
fa40079
Compare
zenzombie
reviewed
Jun 18, 2023
zenzombie
reviewed
Jun 18, 2023
flend
commented
Jun 18, 2023
zenzombie
reviewed
Jun 18, 2023
zenzombie
reviewed
Jun 18, 2023
…even for items without incrementFreq
This comment was marked as resolved.
This comment was marked as resolved.
…o feature/mod_framework
tmewett
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this is too big to stay unmerged for any longer, and it's in a good shape.
Big props for tackling this, we've theorycrafted about it for a while but no one got it across the line until now 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.