Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mod framework #555

Merged
merged 118 commits into from
Jul 20, 2023
Merged

Feature/mod framework #555

merged 118 commits into from
Jul 20, 2023

Conversation

flend
Copy link
Collaborator

@flend flend commented Jun 17, 2023

  • Added Rapid Brogue v1.5 variant and ability to switch to variant at run-time (when game not in progress). Switching variants currently implemented on the command line at game startup only.
  • Adds src/variants. Each variant defines a struct of game constants, its own table variables, and a function to switch the global variables for constants and tables pointers to the variant's own.
  • Many #defines replaced with variant-specific game constants.
  • Globals files tidied up and globals made const where possible. Many color functions now accept const colors.
  • Implemented hard by-level item gen and charm minimum recharge duration, used in Rapid Brogue variant.
  • Game variants have their own high scores file.
  • Variant versions are saved in the recording header, core game version is not saved (since variant version determines recording compatibility).

@flend flend added the draft label Jun 17, 2023
@flend flend force-pushed the feature/mod_framework branch from 4792319 to fa40079 Compare June 17, 2023 21:27
src/brogue/RogueMain.c Outdated Show resolved Hide resolved
src/brogue/RogueMain.c Outdated Show resolved Hide resolved
src/brogue/IO.c Outdated Show resolved Hide resolved
@flend flend marked this pull request as draft June 18, 2023 07:46
@flend

This comment was marked as resolved.

Copy link
Owner

@tmewett tmewett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this is too big to stay unmerged for any longer, and it's in a good shape.

Big props for tackling this, we've theorycrafted about it for a while but no one got it across the line until now 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants