Add static to all functions that should have it, and remove several unused static functions #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flend
approved these changes
Sep 2, 2023
|
Good stuff |
nstoddard
added a commit
to nstoddard/BrogueCE
that referenced
this pull request
Nov 23, 2023
Some of these warnings were directly introduced in tmewett#593; others are due to other PRs that were merged between when I made that PR and when it was merged. Some of these are fixed with new `#define`s; this also makes `displayLoops` and `displayChokeMap` static and always runs them in wizard mode when '~' is pressed, along with `displayMachines` and `displayWaypoints`. This also improves those functions a bit, so it's easier to tell which output is from which function.
nstoddard
added a commit
to nstoddard/BrogueCE
that referenced
this pull request
Nov 26, 2023
Some of these warnings were directly introduced in tmewett#593; others are due to other PRs that were merged between when I made that PR and when it was merged. Some of these are fixed with new `#define`s; this also makes `displayLoops` and `displayChokeMap` static and always runs them in wizard mode when '~' is pressed, along with `displayMachines` and `displayWaypoints`. This also improves those functions a bit, so it's easier to tell which output is from which function.
tmewett
pushed a commit
that referenced
this pull request
Nov 26, 2023
Some of these warnings were directly introduced in #593; others are due to other PRs that were merged between when I made that PR and when it was merged. Some of these are fixed with new `#define`s; this also makes `displayLoops` and `displayChokeMap` static and always runs them in wizard mode when '~' is pressed, along with `displayMachines` and `displayWaypoints`. This also improves those functions a bit, so it's easier to tell which output is from which function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things:
-Wmissing-prototypesto warn about functions that don't have a prototype(void)to prototypes of functions that take no arguments (otherwise the warning doesn't work properly)This doesn't have any gameplay changes.