Fix regression autotarget tunnel & blink staff bug #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Q: Does this make more sense to fix in the next if statement? Instead of using target allies/enemies bolt flag, use magic polarity? I feel like that is the source of the leak - we shouldn't know bolt target from polarity, right? |
|
Sure I can make that change probably this weekend. |
zenzombie
force-pushed
the
regression-autotarget-blink-tunnel
branch
from
3d84045
to
601d2eb
Compare
|
@tmewett Ok I changed the flow. I think it's a lot cleaner now. |
zenzombie
added a commit
to zenzombie/BrogueCE
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where some known good staffs of unknown kind (like blinking and tunneling) would not autotarget enemies, leaking information about the staff kind.