Skip to content

Commit

Permalink
deps: test on node@16.13.0, use npm@9 (#38)
Browse files Browse the repository at this point in the history
- deps: require `node@^16.13.0`, test on `node@16.13.0`
  - this's the ver currently used when running js gh actions
- deps: require `npm@~9.20.0`
  - `npm@9.20.0` is compatible with `node@16.13.0`
  • Loading branch information
tmillr committed Dec 22, 2022
1 parent 8ea50dc commit 8ada988
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 1,940 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/format-and-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ jobs:
format:
if: github.event_name != 'push' || !github.event.deleted
runs-on: ubuntu-latest
env:
npm_config_engine_strict: true
steps:
# NOTE: Be mindful of what gets checked-out for pr events!
- uses: actions/checkout@v3
Expand All @@ -21,6 +19,7 @@ jobs:
node-version-file: package.json
check-latest: true

- run: npm i -g "npm@$(npm pkg get engines.npm | grep -Eom 1 '[^"]+')"
- run: npm ci
- run: npm run format

Expand Down Expand Up @@ -65,8 +64,6 @@ jobs:
needs: format
if: github.event_name != 'push' || !github.event.deleted
runs-on: ubuntu-latest
env:
npm_config_engine_strict: true
steps:
- uses: actions/checkout@v3

Expand All @@ -75,6 +72,7 @@ jobs:
node-version-file: package.json
check-latest: true

- run: npm i -g "npm@$(npm pkg get engines.npm | grep -Eom 1 '[^"]+')"
- run: npm ci
- run: npm run build-docs

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
# All gh runners have at least this version of node16 preinstalled
node-version: 16.18.0
- run: npm ci
node-version: 16.13.0
- run: npm i -g "npm@$(npm pkg get engines.npm | grep -Eom 1 '[^"]+')"
- run: npm ci --engine-strict=false
- run: npm run build --if-present
- run: npm test
env:
Expand Down
Loading

0 comments on commit 8ada988

Please sign in to comment.