Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean strings should be casted to boolean values #14

Open
ostrolucky opened this issue Oct 23, 2024 · 0 comments
Open

Boolean strings should be casted to boolean values #14

ostrolucky opened this issue Oct 23, 2024 · 0 comments

Comments

@ostrolucky
Copy link

ostrolucky commented Oct 23, 2024

From https://datatracker.ietf.org/doc/html/rfc7643#section-2.3.2

Boolean
The literal "true" or "false"

Azure is sending stuff like this via PATCH

{"op":"Replace","path":"roles[primary eq \"True\"].value","value":"employee"}

Here, I would expect return value from ComparisonExpression#compareValue is true. Instead, it's "True".

I suggest using

filter_var($filter->compareValue, FILTER_VALIDATE_BOOLEAN, FILTER_NULL_ON_FAILURE)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant