Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert calls to retry to retry_until #777

Merged
merged 2 commits into from
May 22, 2022

Conversation

categulario
Copy link
Contributor

One test still resists to pass, I think it is the one that didn't pass before retry_until

@tony tony self-requested a review May 21, 2022 16:32
@tony
Copy link
Member

tony commented May 21, 2022

@categulario It has some flake8 stuff to clean (CI currently errors early if linting fails, sorry about that!)

@tony tony linked an issue May 21, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #777 (aedcdf7) into master (827eacf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   75.59%   75.59%           
=======================================
  Files          16       16           
  Lines        1254     1254           
  Branches      322      322           
=======================================
  Hits          948      948           
  Misses        220      220           
  Partials       86       86           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 827eacf...aedcdf7. Read the comment docs.

Copy link
Member

@tony tony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

P.S. I created an issue to improve assertion rewriting with retry_until: tmux-python/libtmux#376

@tony
Copy link
Member

tony commented May 22, 2022

@categulario P.S. Is this still a WIP? Think its good to go in?

@categulario categulario changed the title WIP: convert calls to retry to retry_until convert calls to retry to retry_until May 22, 2022
@categulario
Copy link
Contributor Author

P.S. Is this still a WIP? Think its good to go in?

not anymore! (:

@tony tony merged commit fd2f430 into tmux-python:master May 22, 2022
@tony
Copy link
Member

tony commented May 22, 2022

@categulario Live in v1.12.0a4 pypi, branch, tag

@tony
Copy link
Member

tony commented May 22, 2022

@categulario Woops, forgot to credit you in the CHANGES file. That will be in v1.12.0a5.

@tony
Copy link
Member

tony commented May 24, 2022

@categulario Added mention of you in changelog. That okay, or do you want it changed to be your name?

v1.12.0a5 released

@categulario
Copy link
Contributor Author

Yaay, thank you. categulario is my name for the internet so that's ok (:

@tony
Copy link
Member

tony commented May 24, 2022

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

retry -> retry_until
2 participants