-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert calls to retry to retry_until #777
Conversation
@categulario It has some |
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
=======================================
Coverage 75.59% 75.59%
=======================================
Files 16 16
Lines 1254 1254
Branches 322 322
=======================================
Hits 948 948
Misses 220 220
Partials 86 86 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
P.S. I created an issue to improve assertion rewriting with retry_until: tmux-python/libtmux#376
@categulario P.S. Is this still a WIP? Think its good to go in? |
not anymore! (: |
@categulario Live in v1.12.0a4 pypi, branch, tag |
@categulario Woops, forgot to credit you in the |
@categulario Added mention of you in changelog. That okay, or do you want it changed to be your name? v1.12.0a5 released |
Yaay, thank you. categulario is my name for the internet so that's ok (: |
Sounds good! |
One test still resists to pass, I think it is the one that didn't pass before retry_until