Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean-up and safety #46

Merged
merged 7 commits into from
Nov 15, 2019
Merged

Code clean-up and safety #46

merged 7 commits into from
Nov 15, 2019

Conversation

tnagler
Copy link
Owner

@tnagler tnagler commented Nov 15, 2019

  • Fixed undefined behavior with potential to cause memory issues.
  • Removed dependence on qrng package because it was to heavy (qrng <- copula <- gsl).
  • Prevent rare bw_select() == NaN cases.
  • Fixed compiler warnings due to unused or uninitialized variables.

@tnagler tnagler merged commit 0b801ec into dev Nov 15, 2019
@tnagler tnagler deleted the safety branch November 15, 2019 16:55
tnagler added a commit that referenced this pull request Nov 15, 2019
@tnagler
Patch 1.0.1 (#48)
3a56938 
* Code clean-up and safety (#46)

* code safety

* remove dependence on qrng

* some cleanup

* avoid lower > upper by reversing the grid at the right places

* ensure non-NaN bandwidth

* unused variable

* add randtoolbox to Imports

* Prepare patch (#47)

* code safety

* remove dependence on qrng

* some cleanup

* avoid lower > upper by reversing the grid at the right places

* ensure non-NaN bandwidth

* unused variable

* add randtoolbox to Imports

* update NEWS and DESCRIPTION

* update API docs

* update CRAN comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tnagler