TypeScript: Resolvers(query.task/stats/exportErrors/exportAnnotations): Return toObject() in order to convert _id
to string
#200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any method where a
Task
is returned, we see the following error:This seems to be an issue where GraphQL expected the
_id
to be a string:animl-api/src/@types/graphql.ts
Line 1038 in 27b3e3d
animl-api/src/@types/graphql.ts
Line 10 in 27b3e3d
However, Mongoose shows it as an
mongoose.Types.ObjectId
. Calling.toObject()
on the response object rectifies this. This may become a common pattern for our resolvers... I would like to imagine that there's a better way to handle this, but I'm not sure what that would be, perhaps something with the Scalars for the output?