Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waiting on router.navigate() to show next step #436

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Waiting on router.navigate() to show next step #436

merged 1 commit into from
Nov 19, 2021

Commits on Jul 20, 2021

  1. Waiting on router.navigate() to show next step 

    Encountered some race conditions where the Step Service would try to locate and show the Joyride steps before router.navigate() had finished, and thus before the steps were visible.

Navigation is now async, so we can await before trying to show the step.
    @CodeMagic
    CodeMagic committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    f1b1078 View commit details
    Browse the repository at this point in the history