Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for angular 9 #85

Merged
merged 27 commits into from
Jul 2, 2020
Merged

Add support for angular 9 #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
3156d0d
add support for angular 9
Feb 10, 2020
b83389c
Setting logsEnabled to false as default
tnicola Mar 12, 2020
9b7fccd
Fixing unit test
tnicola Mar 12, 2020
f1d8f6d
Joyride version 2.2.11
tnicola Mar 13, 2020
bc5b2d9
Bump acorn from 6.4.0 to 6.4.1
dependabot[bot] Mar 13, 2020
2d1f755
Improving readme
tnicola Mar 14, 2020
b7fa67b
Cleaning the code
tnicola Mar 14, 2020
d49ad75
Improving readme
tnicola Mar 14, 2020
c47ac98
Merge pull request #90 from tnicola/dependabot/npm_and_yarn/acorn-6.4.1
tnicola Mar 15, 2020
8f45a88
[Security] Bump acorn from 6.4.0 to 6.4.1
dependabot-preview[bot] Mar 15, 2020
7f24ff5
Bump protractor from 5.4.2 to 5.4.3
dependabot-preview[bot] Mar 15, 2020
e3ecfaa
Bump wait-on from 3.3.0 to 4.0.1
dependabot-preview[bot] Mar 15, 2020
1d3493c
Bump @angular-devkit/build-ng-packagr from 0.803.21 to 0.803.25
dependabot-preview[bot] Mar 15, 2020
cab2367
Bump @types/node from 8.9.5 to 13.9.1
dependabot-preview[bot] Mar 15, 2020
6b2ce74
Merge pull request #92 from tnicola/dependabot/npm_and_yarn/acorn-6.4.1
tnicola Mar 15, 2020
45c192a
Merge pull request #93 from tnicola/dependabot/npm_and_yarn/protracto…
tnicola Mar 15, 2020
33ba3a3
Merge pull request #95 from tnicola/dependabot/npm_and_yarn/angular-d…
tnicola Mar 15, 2020
28c7317
Merge pull request #94 from tnicola/dependabot/npm_and_yarn/wait-on-4…
tnicola Mar 15, 2020
52f92be
Bump tslib from 1.10.0 to 1.11.1
dependabot-preview[bot] Mar 15, 2020
9247193
Bump jasmine-core from 3.4.0 to 3.5.0
dependabot-preview[bot] Mar 16, 2020
2f41581
Bump karma-jasmine from 2.0.1 to 3.1.1
dependabot-preview[bot] Mar 17, 2020
70ea3f5
Merge pull request #96 from tnicola/dependabot/npm_and_yarn/types/nod…
tnicola Mar 18, 2020
2ba0d63
Merge pull request #102 from tnicola/dependabot/npm_and_yarn/jasmine-…
tnicola Mar 18, 2020
614fe91
Merge pull request #97 from tnicola/dependabot/npm_and_yarn/tslib-1.11.1
tnicola Mar 18, 2020
cd20d4a
Merge pull request #106 from tnicola/dependabot/npm_and_yarn/karma-ja…
tnicola Mar 18, 2020
6f7f981
add support for angular 9
Feb 10, 2020
76311cb
fix unit tests broken due to angular v9 update
Jul 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
334 changes: 203 additions & 131 deletions README.md
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 7 additions & 3 deletions angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@
"tsConfig": "projects/ngx-joyride/tsconfig.lib.json",
"project": "projects/ngx-joyride/ng-package.json"
},
"showCircularDependencies": false
"showCircularDependencies": false,
"configurations": {
"production": {
"tsConfig": "projects/ngx-joyride/tsconfig.lib.prod.json"
}
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
Expand Down Expand Up @@ -52,7 +57,7 @@
"main": "projects/demo/src/main.ts",
"polyfills": "projects/demo/src/polyfills.ts",
"tsConfig": "projects/demo/tsconfig.app.json",
"aot": false,
"aot": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexsukhodolsky I would be happy to merge it but unfortunately the unit test compilation is failing. Probably due to this change. @lehoffma Can you check this please?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that, but it didn't change the test results for me. The broken unit tests were mostly due to the updated libraries like rxjs I think. I rebased and pushed a fix for the tests, let me know if there's anything else I can do.

"assets": [
"projects/demo/src/favicon.ico",
"projects/demo/src/assets"
Expand All @@ -74,7 +79,6 @@
"sourceMap": false,
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
Expand Down
Loading