Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add --all flag to include private packages #1

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

stieg
Copy link
Contributor

@stieg stieg commented Feb 9, 2020

Without it lerna will only list non-private packages.

Without it lerna will only list non-private packages.
@stieg stieg requested a review from tnobody February 9, 2020 16:54
Copy link
Owner

@tnobody tnobody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stieg thanks for your contribution 👍
I think this is a valuable change. But I'm not sure if I would just like to change the behavior without giving the user to opt-in/out. To be more concrete: I think the user should be able to pass this flag as an opt-in argument on commandline like: npx lerna-audit --all.

What do you think about that?

@stieg
Copy link
Contributor Author

stieg commented Feb 11, 2020

It could be done this way without problem but what I can't think of is a situation why a user might want to exercise such behavior with this tool. If they wish to limit scope of packages then it would be more valuable to support something like --scope argument like lerna instead of the --all argument mentioned above. Perhaps you have an example of why someone may wish not to invoke this script with --all?

@tnobody
Copy link
Owner

tnobody commented Feb 11, 2020

Hi @stieg,

sorry, I'm just really careful when something looks like a breaking change to me. I had a little bit of time to think about the "problem" twice and my view on this had changed since I recognized that the tool cannot work properly when not all information about all packages is loaded at least.

So I'll going to merge this PR and release a new version.

Thanks for contribution 👍

@tnobody tnobody merged commit 88b99b6 into tnobody:master Feb 11, 2020
@stieg
Copy link
Contributor Author

stieg commented Feb 11, 2020

sorry, I'm just really careful when something looks like a breaking change to me.

Don't be sorry. You are being cautious and that is wise. It's better to ask about it and decide its not an issue than just skip by it altogether.

svettwer pushed a commit that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants