Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add empty dependencies/devDependencies fields in package.json #8

Merged
merged 8 commits into from
Apr 1, 2020
Merged

Don't add empty dependencies/devDependencies fields in package.json #8

merged 8 commits into from
Apr 1, 2020

Conversation

svettwer
Copy link
Collaborator

No description provided.

@svettwer svettwer marked this pull request as ready for review March 20, 2020 20:07
@tnobody
Copy link
Owner

tnobody commented Apr 1, 2020

Hi, @svettwer

thank for your contribution. Very nice work 👍
Could you please review the merge conflicts with the latest master branch.

Br

@svettwer
Copy link
Collaborator Author

svettwer commented Apr 1, 2020

Hey @tnobody,

glad you like it. Here is the update including the resolved conflict.

BR

@tnobody tnobody merged commit 6ca71fc into tnobody:master Apr 1, 2020
@svettwer svettwer mentioned this pull request Apr 1, 2020
Closed
@svettwer svettwer deleted the fix/7/dont-add-empty-dependencies branch April 15, 2020 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svettwer @tnobody