fix: Find first source package name for a binary package with published sources #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed sources
If a changelog is not found for a binary package then iterate through list of all source package
for with binaries published of that name - not just the first source package found.
This fixes a problem with metapackages like linux-gce-edge:
```
❯ ubuntu-package-changelog --entries=1 jammy Updates linux-gcp-edge
no changelog found
```
vs (with the commit present)
```
❯ ubuntu-package-changelog --entries=1 jammy Updates linux-gcp-edge
INFO: No published sources found for linux-gcp-edge in jammy Updates
INFO: Trying to find a binary package with that name ...
INFO: Found source package linux-meta-gcp-6.2 for binary package linux-gcp-edge with published sources.
INFO: Changelog for source package linux-meta-gcp-6.2 will be parsed
linux-meta-gcp-6.2 (6.2.0.1010.10~22.04.1) jammy; urgency=medium
* Bump ABI 6.2.0-1010.10~22.04
* Packaging resync (LP: #1786013)
- [Packaging] resync debian/dkms-versions from main package
-- Khalid Elmously <khalid.elmously@canonical.com> Tue, 18 Jul 2023 04:39:30 -0400
```
The source packages are sorted by date with newest first so we will always have the latest returned.
In this instance it is a metadata package which will not have a very informative changleog but it
is more helpful than no changelog and at least it is known what the source package name is.
kajiya3141
approved these changes
Sep 15, 2023
toabctl
approved these changes
Sep 16, 2023
SamirPS
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a changelog is not found for a binary package then iterate through list of all source package for with binaries published of that name - not just the first source package found.
This fixes a problem with metapackages like linux-gce-edge:
vs (with the commit present)
The source packages are sorted by date with newest first so we will always have the latest returned.
In this instance it is a metadata package which will not have a very informative changleog but it is more helpful than no changelog and at least it is known what the source package name is.