fix: ensure keyring module is installed and available to use when querying private PPAs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rying private PPAs Similar to https://github.com/canonical/ubuntu-package-status/pull/9/commits for ubuntu-package-status `keyring` is required when accessing private PPAs. This fixes error when run as a snap. ``` Traceback (most recent call last): File "/snap/ubuntu-package-changelog/159/bin/ubuntu-package-changelog", line 8, in <module> sys.exit(main()) File "/snap/ubuntu-package-changelog/159/lib/python3.8/site-packages/ubuntu_package_changelog/__init__.py", line 109, in main lp = Launchpad.login_with( File "/snap/ubuntu-package-changelog/159/lib/python3.8/site-packages/launchpadlib/launchpad.py", line 700, in login_with return cls._authorize_token_and_login( File "/snap/ubuntu-package-changelog/159/lib/python3.8/site-packages/launchpadlib/launchpad.py", line 445, in _authorize_token_and_login cached_credentials = credential_store.load( File "/snap/ubuntu-package-changelog/159/lib/python3.8/site-packages/launchpadlib/credentials.py", line 345, in load return self.do_load(unique_key) File "/snap/ubuntu-package-changelog/159/lib/python3.8/site-packages/launchpadlib/credentials.py", line 423, in do_load self._ensure_keyring_imported() File "/snap/ubuntu-package-changelog/159/lib/python3.8/site-packages/launchpadlib/credentials.py", line 388, in _ensure_keyring_imported import keyring ModuleNotFoundError: No module named 'keyring' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to https://github.com/canonical/ubuntu-package-status/pull/9/commits for ubuntu-package-status
keyringis required when accessing private PPAs.This fixes error when run as a snap.