Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt for CBA JAM #117

Merged
merged 6 commits into from
Oct 24, 2018
Merged

Adapt for CBA JAM #117

merged 6 commits into from
Oct 24, 2018

Conversation

robalo
Copy link
Collaborator

@robalo robalo commented Sep 28, 2018

left the RHS magwells in place as well

NIA_belts[] = { __792MG42_MAGS };
};
class CBA_762x51_LINKS {
NIA_MG3_belts[] = { __762MG3_MAGS };
Copy link
Contributor

@Blutze Blutze Sep 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are using DM6 links, not M13. Should be a separate magwell class, MG3 weapons having both or only their own one. See #79 (comment)

Or maybe I'm just an idiot. Nevermind.

@robalo
Copy link
Collaborator Author

robalo commented Sep 30, 2018

Thanks, fixed.

@Drofseh
Copy link

Drofseh commented Sep 30, 2018

@robalo
DM6 links are the same as M13 links. DM6 is just the German army name for them.
The earlier DM1 links are the incompatible ones. ref: all the comments below #79

I'm also adding CBA_762x51_MG3 in CBATeam/CBA_A3#995 to cover DM1.

@robalo
Copy link
Collaborator Author

robalo commented Oct 2, 2018

@Drofseh Did I get it right this time ?

@Drofseh
Copy link

Drofseh commented Oct 2, 2018

@robalo use CBA_762x51_MG3 for DM1 links and CBA_762x51_LINKS for M13/DM6/DM60 links

@robalo
Copy link
Collaborator Author

robalo commented Oct 2, 2018

@robalo use CBA_762x51_MG3 for DM1 links and CBA_762x51_LINKS for M13/DM6/DM60 links

yep, just like in my last commit, right ? I mean, not sure if any MG3 can take both types, like I set it up.

@Drofseh
Copy link

Drofseh commented Oct 2, 2018

I see you've added CBA_762x51_MG3 to the MG3 weapon but I don't see in your magwells at all.
I am assuming the MG3 belts in CfgMagazines are supposed to be DM1 links.

class hlc_250Rnd_762x51_T_MG3 : hlc_50Rnd_762x51_T_MG3 {
dlc = "Niarms_MG3";
author = "Toadie, Spartan0536";
count = 250;
descriptionshort = "Caliber: 7.62x51mm M62A1 <br />Type: Incendiary Tracer <br />Rounds: 250";
displayname = "7.62mm Tracer 250Rnd DM6-Linked Belt";
mass = 110;
};
};
class CfgMagazineWells {
class CBA_792x57_LINKS {
NIA_belts[] = { __792MG42_MAGS };
};
class CBA_762x51_LINKS {
NIA_MG3_belts[] = { __762MG3_MAGS };
};
};

@robalo
Copy link
Collaborator Author

robalo commented Oct 2, 2018

Nope, actually seeing the config strings they're supposed to be DM6:
displayname = "7.62mm Tracer 250Rnd DM6-Linked Belt";

@Drofseh
Copy link

Drofseh commented Oct 2, 2018

Ahh, ok. I was just looking at the classname.

@robalo robalo changed the title Adapt for upcoming CBA JAM Adapt for CBA JAM Oct 16, 2018
@toadie2k toadie2k merged commit 8b52568 into master Oct 24, 2018
@robalo robalo deleted the jamtoo branch October 24, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants