Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 Syntax #2

Open
acushlakoncept opened this issue Jul 9, 2020 · 2 comments
Open

ES6 Syntax #2

acushlakoncept opened this issue Jul 9, 2020 · 2 comments

Comments

@acushlakoncept
Copy link

Great Job @tobi-bams !!! 👏

  • I noticed you used const which is an ES6 new syntax. It's a good practice to follow suit with the var by replacing it with let
  • Follow the DRY (Do-Not-Repeat-Yourself) principle in your code. You can call some of the elements you use more than once into their own separate const like the document.getElementById('getter') in your validate.js it's been called like 9 times.
    Imaging changing the ID name in the main code, that means you have to change it in 9 places.

Happy Coding !!! 👍

@tobi-bams
Copy link
Owner

tobi-bams commented Jul 9, 2020 via email

@acushlakoncept
Copy link
Author

You're welcome @tobi-bams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants