Skip to content

Commit

Permalink
Correct documentation of Drag/LiftedDrag
Browse files Browse the repository at this point in the history
As discussed in qiskit-terra issue Qiskit#7659, the definition of the LiftedDrag pulse was not consistent with its implementation in qiskit.pulse.library.continuous.py.
One error is fixed by this PR.
A remaining problem is the explicit definition of the sampler strategy. This should be fixed after/with the update of parametric pulses, qiskit-terra issue  Qiskit#7821.
  • Loading branch information
tobias-kehrer authored Apr 1, 2022
1 parent afb9c9e commit a5a1302
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion qiskit/pulse/library/parametric_pulses.py
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,8 @@ class Drag(ParametricPulse):
f'(x) &= g(x) + 1j \\times \\text{beta} \\times \\frac{\\mathrm d}{\\mathrm{d}x} g(x)\\\\
&= g(x) + 1j \\times \\text{beta} \\times\
\\Bigl(-\\frac{x - \\text{duration}/2}{\\text{sigma}^2}\\Bigr)g(x)\\\\
f(x) &= \\text{amp}\\times\\frac{f'(x)-f'(-1)}{1-f'(-1)}, \\quad 0 \\le x < \\text{duration}
f(x) &= \\text{amp}\\times\\frac{g(x)-g(-1)}{1-g(-1)} \\times \\Bigl(1 + 1j \\times \\text{beta} \\times\
\\Bigl(-\\frac{x - \\text{duration}/2}{\\text{sigma}^2}\\Bigr) \\Bigr), \\quad 0 \\le x < \\text{duration}
where :math:`g(x)` is a standard unlifted gaussian waveform and
:math:`f'(x)` is the DRAG waveform without lifting or amplitude scaling.
Expand Down

0 comments on commit a5a1302

Please sign in to comment.