fixed typoes in readme and fixed error in MHZ.cpp files #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plz merge the branch to correct the readme, thanks. |
added 2 commits
August 10, 2021 18:28
In Uno, it's 16 bits in int variable. So I add a explicit type cast in MHZ.cpp file
I change the data type to unit_8t, and it also helps to unify the datatype of these cmd arrays.
|
CollieIsCute
changed the title
CollieIsCute
changed the title
tobiasschuerg
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that a type name of sensor in readme, "MH-Z18B", isn't found in the header. I've also googled "MH-Z18B", but I didn't find anything relative.
I guess you mean the "MH-Z19B" CO2 sensor, so I correct it. If I make any mistake, please let me know, tks.