Remove Teradata CREATE args from Snowflake create_sql #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been meaning to pull most of those args into a new "properties" location so we can use the properties machinery and dialect-specific unsupported approach |
tobymao
reviewed
Feb 21, 2023
| @@ -327,3 +327,10 @@ def generatedasidentitycolumnconstraint_sql( | |||
| increment = expression.args.get("increment") | |||
| increment = f" INCREMENT {increment}" if increment else "" | |||
| return f"AUTOINCREMENT{start}{increment}" | |||
|
|
|||
| def create_sql(self, expression: exp.Create) -> str: | |||
There was a problem hiding this comment.
delete this and make a new propety location unsupported, then snowflake just needs to override the properties_location
| def create_sql(self, expression: exp.Create) -> str: | ||
| unsupported = ["set", "multiset", "global_temporary", "volatile"] | ||
| for prop in unsupported: | ||
| expression.set(prop, False) |
There was a problem hiding this comment.
We shouldn't mutate any expression in the generator. Whenever something like this is needed, you first need to copy it.
Comment on lines
+335
to
+336
| create_sql = super().create_sql(expression) | ||
| return create_sql |
There was a problem hiding this comment.
Suggested change
| create_sql = super().create_sql(expression) | |
| return create_sql | |
| return super().create_sql(expression) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1205