New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for old (+) join syntax #1224

Merged

tobymao merged 1 commit into main from old_join_syntax_fixes

Feb 24, 2023

Collaborator

georgesittas commented Feb 24, 2023 •

edited

Loading

Fixes #648

I only added this in exp.Column, because the Oracle docs suggest that it can't be used elsewhere:

The (+) operator can appear only in the WHERE clause or, in the context of left-correlation (when specifying the TABLE clause) in the FROM clause, and can be applied only to a column of a table or view.

In the future, we could try to transform these old syntax forms into the new ones (i.e. INNER JOIN, LEFT JOIN, etc).


          Add support for old (+) join syntax

abe7e36

tobymao approved these changes

View reviewed changes

tobymao merged commit 08d7e8f into main

tobymao deleted the old_join_syntax_fixes branch

February 24, 2023 16:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet