fix(bigquery)!: Inline type-annotated ARRAY literals

[VaggelisD]

Fixes #4670

#3751 canonicalized BigQuery's inlined constructors into casts which may not be correct for certain roundtrips, as shown in the issue:

• Safe

bq> SELECT ARRAY<INT64>[1, 2, 3], CAST([1, 2, 3] AS ARRAY<INT64>);
f0_	f1_
"[1,2,3]"	"[1,2,3]"

• Not safe (type mismatch)

bq> SELECT CAST([1, 2, 3] AS ARRAY<FLOAT64>);
Casting between arrays with incompatible element types is not supported: Invalid cast from ARRAY<INT64> to ARRAY<FLOAT64> at [1:13]

This PR fixes this particular scenario by preserving the inlined ARRAY type annotation & literal value for BQ's roundtrip.

Docs

BQ ARRAY Literals

[georgesittas]

Does this only concern arrays? What about structs?

[VaggelisD]

Yep, I tried STRUCT related queries in a similar fashion but I don't think the same typing issue arises, e.g this is fine:

bq> SELECT STRUCT<FLOAT64>(1), CAST(STRUCT(1) AS STRUCT<FLOAT64>);
f0_	f1_
"{
  ""f0_"": {
    ""_field_1"": ""1.0""
  }
}"	"{
  ""f1_"": {
    ""_field_1"": ""1.0""
  }
}"

Would you have other (possibly offending) scenarios in mind?

[georgesittas]

Cool, no this is what I had in mind.

[sean-rose]

Yep, I tried STRUCT related queries in a similar fashion but I don't think the same typing issue arises, e.g this is fine:

While casting STRUCTs like that doesn't result in an outright BigQuery error, IMO it'd be preferable to also preserve BigQuery's typed struct literal syntax since it's more idiomatic, succinct, and avoids BigQuery potentially doing more work to first construct theSTRUCT and then convert it (I'm speculating on this last point).

[georgesittas]

Makes sense. @VaggelisD can we try to preserve these constructors when roundtripping BigQuery SQL?

[VaggelisD]

Yep, will give it a shot.