TSQL support for lateral joins #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 25, 2022 16:58
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
tobymao
reviewed
Oct 26, 2022
georgesittas
approved these changes
Oct 27, 2022
|
great, except i'm going to remove the "inner" join as default is just join |
|
thanks again for the great pr @10bas10 |
|
i believe this also fixes a bug because in the previous code, the OUTER was always getting set to False since you always did outer = self._match(TokenType.OUTER) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the CROSS APPLY and OUTER APPLY from T-SQL. In order to achieve this I had to add the "view" attribute to make the distinction between LATERAL VIEW and LATERAL JOINS.