-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type inheritance for functions based on args #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. We should add some tests that cover other argument types too; for instance we should check the case where we have a list of expressions or a single expression, instead of just strings.
This seems like a reasonable addition, thanks for the PR!
I could also clean that part out as I dont see a usecase yet for it. What do you think? |
Yes, that could work too. I initially thought that strings would probably suffice for this function. |
Made a new function to support type inheritance for specific functions that should only inherit from specific attributes. The function allows one of the following parameters:
From the list of expressions applicable, the datatype will be inherited.