Refactor comments so they're stored in a list #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobymao
reviewed
Nov 22, 2022
tobymao
reviewed
Nov 22, 2022
georgesittas
force-pushed
the
comment_refactor
branch
from
5371c51
to
bf7ea18
Compare
|
@tobymao I experimented with the comment formatting a bit and removed the (*) Before, we generated Note to self: if current state of the PR is good to go, should update README example first. |
tobymao
reviewed
Nov 23, 2022
tobymao
reviewed
Nov 23, 2022
georgesittas
force-pushed
the
comment_refactor
branch
from
8eeeac9
to
9e092f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind this PR can be found in this conversation. It's still a WIP, since I haven't tweaked the generator to allow for multiple comment printing, but it'll come soon.
cc: @mpf82