Use reserved space footer for padding #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elf2tab supports two types of padding: 1) creating a reserved space footer or 2) just adding bytes to the binary. The need to do both is because a reserved space footer can only pad 8 or more bytes. This patch fixes an issue where the padding needed is less than 8, but, there is already going to be a reserved footer. In that case, we were adding the padding twice (once in the reserved footer and again as just extra bytes). This issue only arises if you ask for a certain amount of footer space when running elf2tab.
ppannuto
approved these changes
May 7, 2024
lschuermann
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elf2tab supports two types of padding at the end of a TBF file: 1) creating a reserved space TBF footer or 2) just adding bytes to the binary. The need to support both is because a reserved space footer can only pad 8 or more bytes.
This patch fixes an issue where the padding needed is less than 8, but, there is already going to be a reserved footer. In that case, we were adding the padding twice (once in the reserved footer and again as just extra bytes).
This issue only arises if you ask for a certain amount of footer space when running elf2tab.