Update the Rust toolchain to 2021-03-25. #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes rust-lang/rust#82141, which is needed in order to add ARM support to libtock_runtime. It also allows us to use the unsafe_op_in_unsafe_fn lint.
jrvanwhy
added
the
significant
|
CI failure will be fixed when #279 is merged. I'll re-run the CI then. |
hudson-ayers
approved these changes
Mar 30, 2021
Good catch, I missed that when I wrote the PR description! After the toolchain update, the |
|
bors r+ |
alistair23
approved these changes
Mar 31, 2021
|
The CI failure looks unrelated, I'm going to manually merge this as I don't think a toolchain update is significative (in the sense we should wait a week for comments) |
|
Already running a review |
bors bot
added a commit
that referenced
this pull request
Apr 6, 2021
282: Overhaul RawSyscalls to work with ARM, -Zmiri-track-raw-pointers, the revised Yield, and Exit. r=alistair23 a=jrvanwhy 1. RawSyscalls now supports Yield's new return value semantics as well as the `yield-no-wait` variant of Yield. 2. RawSyscalls now supports Exit. 3. RawSyscalls is now usable in Miri with the `-Zmiri-track-raw-pointers` flag. 4. RawSyscalls can now be implemented on ARM: previously, `class` was a runtime value, but it needs to be an immediate value on ARM. 5. The explanation for the design of RawSyscalls was completely overhauled. Instead of listing a bunch of "design considerations" with no connection to the final design, it shows how testing and efficiency considerations lead to its design. I hope the new description is more amenable to discussion. The new design should be a bit more future-proof than the previous design as well. The new features added have been stabilized, and can be removed after #280 is merged. Co-authored-by: Johnathan Van Why <jrvanwhy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes rust-lang/rust#82141, which is needed in order to add ARM support to
libtock_runtime. It also allows us to use theunsafe_op_in_unsafe_fnlint.I went ahead and turned on
unsafe_op_in_unsafe_fnfor the Tock 2.0 crates, as I will use that setting in upcoming PRs (in addition to warning on one pattern, it also allows you to useunsafe {}inunsafefunctions).The toolchain update caused a change in the ELF file generation, which caused elf2tab to identify the wrong flash range for the process binary. To solve this, I moved
startout of.textand merged it into.crt0_headerto form a new.startsection. I believe the issue has to do with execute bits on the sections, but it was nontrivial to fix in elf2tab.The remainder of the changes are a result of additional lints added in the new toolchain version.