-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci workflow #5
Ci workflow #5
Conversation
As this uses git in the action commands, this might not work with merge queue. I suggest we merge this and try. |
For the merge queue to work, it might need the Footnotes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I figure just give it a shot!
2ba043f
This change should enable the CI tests to run on the merge queue if the repository is configured correctly. A note on settingsFor the merge queue to function as expected, it seems that both the "Require merge queue" and "Require status checks to pass before merging" need to both be active at the the same time (Thanks to @alexandruradovici for discovering this). If the second rule is not present, the merge queue will not stop a failing PR from being merged. I've documented my test attempts over here UPB-CS-OpenSourceUpstream#14 |
Did it run all the tests while in the merge queue? |
Yes, it ran all of them. |
As soon as @hudson-ayers approves it, I will merge this manually and enable the merge queue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this slipped through the cracks, but looks good!
Merged & merge queue enabled on main branch |
This PR contains the implementation of a basic CI workflow for rust.
In short, when someone pushes or makes a pull request, the following tests are performed:
cargo build
succeedscargo test
)The Makefile has also been updated so that the
ci-runner-github
matches the same tests that are done by the CI Workflow (it wasn't runningcargo test
previously).Also, here is a sample pull requests that fails: george-cosma#1