Skip to content

Commit

Permalink
minor build fix for Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
todbot committed Aug 22, 2020
1 parent fe02e78 commit 68313f9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ npm run build
```

Notes:
- On MacOS, running `npm run build` will attempt to sign and notarize the app. This takes several minutes and requires setting the environment variables:
- `APPLEID` -- developer Apple ID
- `APPLEIDPASSWD` -- app-specific password for above Apple ID
- `TEAM_SHORT_NAME` -- team short name, as provided by `/Applications/Transporter.app/Contents/itms/bin/iTMSTransporter -m provider -u $APPLEID -p $APPLEIDPASSWD`

- Uses the magic of `require('babel-register')` in both the app and renderer to do on-the-fly React transpiling

Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dev": "cross-env NODE_ENV='development' npm run start",
"dist": "cross-env electron-builder",
"dist-debug": "cross-env DEBUG=electron-builder electron-builder",
"build": "electron-builder .",
"build": "electron-builder",
"reload": "live-reload app --port 35729",
"rebuild": "electron-rebuild",
"electron-rebuild": "electron-rebuild",
Expand All @@ -33,6 +33,7 @@
"provider": "github"
},
"mac": {
"target": "zip",
"category": "public.app-category.utilities",
"icon": "pkg/icon.icns",
"gatekeeperAssess": false,
Expand Down

0 comments on commit 68313f9

Please sign in to comment.